Windows symlinks #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating both blob and snapshot folders when symlinks aren't supported is just taking double the space for no reason. This change follows the Python package's logic for handling this case--just don't have a blobs folder.
jcheng5
force-pushed
the
windows-symlinks
branch
from
b9accb7 to
899fc78
Compare
Author
|
Fixes #10 |
Author
|
I only tested this on Windows, in 1) non-Admin, non-Developer mode, and 2) Admin, non-Developer mode. (No Mac or Linux) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, creating symlinks requires either administrator privileges or developer mode. When these aren't available,
hub_download()fails silently:blobs/file.symlink()fails and returnsFALSEsnapshots/directory remains emptyThis PR fixes the problem by putting the files directly in snapshots when
file.symlink()fails. This is less space efficient when there are multiple snapshots for a model, but it does work.The Python huggingface_hub implementation has similar behavior to this.